Fix and extend push webhook documentation.#499
Merged
lucascosti merged 3 commits intogithub:mainfrom Oct 20, 2020
Merged
Conversation
When setting up a webhook recently I found the objects in the commits array did not have an 'sha' element, but did have an 'id'.
Document the timestamp, added, modified and removed keys of the commit object.
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Contributor
|
Thanks so much for opening a PR @coling! I'll get this triaged for review ⚡ |
janiceilene
added
content
lucascosti
approved these changes
Oct 20, 2020
Contributor
lucascosti
left a comment
lucascosti
left a comment
There was a problem hiding this comment.
Thanks a lot for this, @coling! I'll get this merged in 🚀
Contributor
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
This was referenced Jul 7, 2022
This was referenced Jul 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
I implemented a webhook to handle pushes but the payload was not the same as the docs. I found the commits had an id attribute rather than an sha one as per the docs.
What's being changed:
Check off the following: